Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving simulator tests so they are distributed as part of Prescient #139

Merged
merged 6 commits into from
Mar 1, 2022
Merged

Moving simulator tests so they are distributed as part of Prescient #139

merged 6 commits into from
Mar 1, 2022

Conversation

bknueven
Copy link
Collaborator

For downstream packages, it would be nice to make our simulator regression test code accessible; see IDAES/idaes-pse#652, IDAES/idaes-pse#638, and gmlc-dispatches/dispatches#80.

This PR move the simulator regression test code into the simulator directory, so one can import the base-class regression checker as:

from prescient.simulator.tests.test_simulator import SimulatorRegressionBase

and use SimulatorRegressionBase for their own regression tests.

@bknueven
Copy link
Collaborator Author

@xiangao1 would you mind having a look at this?

@bknueven bknueven mentioned this pull request Feb 28, 2022
Merged
jsiirola
jsiirola requested changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. However, you will also need to update the package_data directive in the setup.py to pick up (and package) the non-*.py files in the tests.

prescient/simulator/tests/test_simulator.py Show resolved Hide resolved
@bknueven bknueven requested a review from jsiirola February 28, 2022 23:45
@bknueven bknueven enabled auto-merge (squash) February 28, 2022 23:46
@bknueven bknueven disabled auto-merge March 1, 2022 00:36
@darrylmelander darrylmelander merged commit d7d92be into grid-parity-exchange:main Mar 1, 2022
@bknueven bknueven deleted the move_regression_tests branch March 1, 2022 00:37
bknueven added a commit to grid-parity-exchange/Egret that referenced this pull request Mar 1, 2022
@bknueven
updating location of Prescient regression tests for grid-parity-excha…
4b91fdd 
…nge/Prescient#139
This was referenced Mar 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrylmelander darrylmelander darrylmelander approved these changes

@jeanpaulwatson jeanpaulwatson Awaiting requested review from jeanpaulwatson

@jsiirola jsiirola Awaiting requested review from jsiirola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bknueven @jsiirola @darrylmelander